Unable to compile ReadyNASOS 6.9.0 kernel

[iamthemitch]

Hi,

Initial topic has been closed (https://community.netgear.com/t5/Community-Add-ons/Missing-GPL-Source-for-ReadyNAS-6-8-1/m-p/1407561), but we are not able to compile ReadyNASOS 6.9.0 kernel.

 LD fs/case/built-in.o
 CC fs/cifs/cifsfs.o
 CC fs/cifs/cifssmb.o
 CC fs/cifs/cifs_debug.o
 CC fs/cifs/connect.o

In file included from include/linux/kernel.h:13:0,
                 from include/linux/list.h:8,
                 from include/linux/wait.h:6,
                 from include/linux/fs.h:5,
                 from fs/cifs/connect.c:21:
fs/cifs/connect.c: In function ‘server_unresponsive’:
fs/cifs/connect.c:510:34: error: ‘struct TCP_Server_Info’ has no member named ‘echo_interval’
     server->hostname, (2 * server->echo_interval) / HZ);
                                  ^
include/linux/printk.h:410:50: note: in definition of macro ‘pr_debug_ratelimited’
   __dynamic_pr_debug(&descriptor, pr_fmt(fmt), ##__VA_ARGS__); \
                                                  ^
fs/cifs/connect.c:509:3: note: in expansion of macro ‘cifs_dbg’
   cifs_dbg(VFS, "Server %s has not responded in %lu seconds. Reconnecting...\n",
   ^
In file included from fs/cifs/connect.c:49:0:
fs/cifs/connect.c:510:34: error: ‘struct TCP_Server_Info’ has no member named ‘echo_interval’
     server->hostname, (2 * server->echo_interval) / HZ);
                                  ^
fs/cifs/cifs_debug.h:58:23: note: in definition of macro ‘cifs_dbg’
   cifs_vfs_err(fmt, ##__VA_ARGS__);   \
                       ^
In file included from include/linux/kernel.h:13:0,
                 from include/linux/list.h:8,
                 from include/linux/wait.h:6,
                 from include/linux/fs.h:5,
                 from fs/cifs/connect.c:21:
fs/cifs/connect.c:510:34: error: ‘struct TCP_Server_Info’ has no member named ‘echo_interval’
     server->hostname, (2 * server->echo_interval) / HZ);
                                  ^
include/linux/printk.h:410:50: note: in definition of macro ‘pr_debug_ratelimited’
   __dynamic_pr_debug(&descriptor, pr_fmt(fmt), ##__VA_ARGS__); \
                                                  ^
fs/cifs/connect.c:509:3: note: in expansion of macro ‘cifs_dbg’
   cifs_dbg(VFS, "Server %s has not responded in %lu seconds. Reconnecting...\n",
   ^
scripts/Makefile.build:258: recipe for target 'fs/cifs/connect.o' failed
make[2]: *** [fs/cifs/connect.o] Error 1
scripts/Makefile.build:403: recipe for target 'fs/cifs' failed
make[1]: *** [fs/cifs] Error 2
Makefile:964: recipe for target 'fs' failed
make: *** [fs] Error 2 

Any reason ?

Rgds,

[mdgm-ntgr]

Did you compile previous kernels successfully?

[iamthemitch]

Yes
Compile was fine on 6.8.0 and 6.8.1
jpearn has been able to compile 6.9.0 by replacing fs/cifs with the one from 6.8.1.
I didn't had the chance to try this workarounfd for now.

[Skywalker]

$ diff -u fs/cifs/connect.c.orig fs/cifs/connect.c
--- fs/cifs/connect.c.orig	2017-10-28 12:34:28.328786905 +0200
+++ fs/cifs/connect.c	2017-10-28 12:35:38.069563894 +0200
@@ -507,7 +507,7 @@
 	    server->tcpStatus == CifsNeedNegotiate) &&
 	    time_after(jiffies, server->lstrp + 2 * SMB_ECHO_INTERVAL)) {
 		cifs_dbg(VFS, "Server %s has not responded in %lu seconds. Reconnecting...\n",
-			 server->hostname, (2 * server->echo_interval) / HZ);
+			 server->hostname, (2 * SMB_ECHO_INTERVAL) / HZ);
 		cifs_reconnect(server);
 		wake_up(&server->response_q);
 		return true;

[Skywalker]

BTW, 6.9.1 was released last week.

[iamthemitch]

at least, the error match the diff.

1/ the workaroud sounds safe

2/ shouldn't be to hard to correct the 6.9.0 sources zip file